-
Notifications
You must be signed in to change notification settings - Fork 8.1k
STM32WBAX PM rework to support STOP/STDBY modes #92847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32WBAX PM rework to support STOP/STDBY modes #92847
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @asm5878, thanks a lot for this draft PR, very interesting proposal. I added few preliminary comments, and I would like also to involve @HoZHel and @FrancescoCiminoST
e119b24
to
a58e6c7
Compare
ac8ec9f
to
b1e2b46
Compare
c8a0cd8
to
67e08da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. For some reason I can’t “resolve conversations” (button is not shown for me). If you can, you can mark all my conversations resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
67e08da
to
11e0232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM AFAICT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
west.yml
Outdated
- hal | ||
- name: hal_stm32 | ||
revision: 611d54c237623ea71a367502bfbd736fc67ba15f | ||
revision: pull/294/head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3a4b521441607646ec43bece2c53f333ce7f9b69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @erwango . Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflict.... Rebase on going
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and conflict solved
0201e99
11e0232
to
0201e99
Compare
soc power management rework to support power states removing dependency on ST system clock manager (SCM). Signed-off-by: Alessandro Manganaro <[email protected]>
Updating standby exit latency time according worst case value from stm32wba5 and stm32wba6 datasheets. Signed-off-by: Alessandro Manganaro <[email protected]>
0201e99
to
b4e6338
Compare
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Aim of this PR is a cleaner support of stop/stdby modes for stm32wbax socs.
System power management has been reworked to remove:
Scope of this PR has been reduced to manage only the pm at system level.
A new PR (#95151) has been created to update the pm for the stm32wbax ble hci driver.
FYI: @Chastillon